From: Thomas Huth <thuth@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>, kvm@vger.kernel.org
Cc: frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com,
imbrenda@linux.ibm.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 1/2] Makefile: Fix cscope
Date: Thu, 26 Aug 2021 07:07:56 +0200 [thread overview]
Message-ID: <1dd4c64e-3866-98c9-8178-dbff90dca55f@redhat.com> (raw)
In-Reply-To: <1629908421-8543-2-git-send-email-pmorel@linux.ibm.com>
On 25/08/2021 18.20, Pierre Morel wrote:
> In Linux, cscope uses a wrong directory.
> Simply search from the directory where the make is started.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f7b9f28c..c8b0d74f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -119,7 +119,7 @@ cscope: cscope_dirs = lib lib/libfdt lib/linux $(TEST_DIR) $(ARCH_LIBDIRS) lib/a
> cscope:
> $(RM) ./cscope.*
> find -L $(cscope_dirs) -maxdepth 1 \
> - -name '*.[chsS]' -exec realpath --relative-base=$(PWD) {} \; | sort -u > ./cscope.files
> + -name '*.[chsS]' -exec realpath --relative-base=. {} \; | sort -u > ./cscope.files
Why is $PWD not pointing to the same location as "." ? Are you doing in-tree
or out-of-tree builds?
Thomas
next prev parent reply other threads:[~2021-08-26 5:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 16:20 [kvm-unit-tests PATCH 0/2] Two fixes for KVM unit tests Pierre Morel
2021-08-25 16:20 ` [kvm-unit-tests PATCH 1/2] Makefile: Fix cscope Pierre Morel
2021-08-26 5:07 ` Thomas Huth [this message]
2021-08-27 9:26 ` Pierre Morel
2021-08-27 10:22 ` Andrew Jones
2021-09-20 13:27 ` Paolo Bonzini
2021-09-20 14:10 ` Andrew Jones
2021-09-20 18:04 ` Paolo Bonzini
2021-09-21 6:58 ` Andrew Jones
2021-08-27 10:22 ` Thomas Huth
2021-08-25 16:20 ` [kvm-unit-tests PATCH 2/2] s390x: fixing I/O memory allocation Pierre Morel
2021-08-25 16:31 ` Claudio Imbrenda
2021-08-27 9:39 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dd4c64e-3866-98c9-8178-dbff90dca55f@redhat.com \
--to=thuth@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox