From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, lvivier@redhat.com, kvm-ppc@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] powerpc: Fix endless loop that occurs without a device tree
Date: Tue, 30 May 2017 19:36:53 +0200 [thread overview]
Message-ID: <1f121e1c-4b71-54e6-820e-11056aa13603@redhat.com> (raw)
In-Reply-To: <2d7b5b2e-3ea6-1203-9fdd-2d2ac047f159@redhat.com>
On 30/05/2017 18:13, Thomas Huth wrote:
> On 30.05.2017 17:19, Paolo Bonzini wrote:
>>
>>
>> On 30/05/2017 17:07, Thomas Huth wrote:
>>> , NULL, -1, -1);
>>> + int token, ret;
>>> +
>>> + token = rtas_token("power-off");
>>> + if (token < 0) {
>>> + puts("RTAS power-off not available\n");
>>> + return;
>>> + }
>>
>> Should this do some kind of infinite loop (Linux arch/x86 has play_dead
>> which does cli;hlt, not sure if there's something similar for sPAPR)?
>
> The exit() function in lib/powerpc/io.c already calls halt() after
> trying to run rtas_power_off() ... I think that should be enough here.
Indeed, thanks!
Paolo
next prev parent reply other threads:[~2017-05-30 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 15:07 [kvm-unit-tests PATCH] powerpc: Fix endless loop that occurs without a device tree Thomas Huth
2017-05-30 15:19 ` Paolo Bonzini
2017-05-30 16:13 ` Thomas Huth
2017-05-30 17:36 ` Paolo Bonzini [this message]
2017-05-31 8:21 ` Andrew Jones
2017-05-31 8:32 ` Thomas Huth
2017-05-31 9:00 ` Laurent Vivier
2017-05-31 9:27 ` Thomas Huth
2017-05-31 8:29 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f121e1c-4b71-54e6-820e-11056aa13603@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).