Re: [PATCH 12/14] KVM: x86 emulator

["Hesse, Christian" <mail@earthworm.de>]

[-- Attachment #1: Type: text/plain, Size: 2107 bytes --]

On Tuesday 07 November 2006 13:55, Avi Kivity wrote:
> Pavel Machek wrote:
> >> Index: linux-2.6/drivers/kvm/x86_emulate.c
> >> ===================================================================
> >> --- /dev/null
> >> +++ linux-2.6/drivers/kvm/x86_emulate.c
> >> @@ -0,0 +1,1370 @@
> >> +/**********************************************************************
> >>******** + * x86_emulate.c
> >> + *
> >> + * Generic x86 (32-bit and 64-bit) instruction decoder and emulator.
> >> + *
> >> + * Copyright (c) 2005 Keir Fraser
> >> + *
> >> + * Linux coding style, mod r/m decoder, segment base fixes, real-mode
> >> + * privieged instructions:
> >> + *
> >> + * Copyright (C) 2006 Qumranet
> >> + *
> >> + *   Avi Kivity <avi@qumranet.com>
> >> + *   Yaniv Kamay <yaniv@qumranet.com>
> >> + *
> >> + * From: xen-unstable 10676:af9809f51f81a3c43f276f00c81a52ef558afda4
> >> + */
> >
> > This needs GPL, I'd say.
> > 									Pavel
>
> The entire patchset is GPL'ed.  Do you mean to make it explicit?  If so,
> how?  I'd rather not copy the entire license into each file.
>
> Doesn't ../../COPYING cover it, presuming it's accepted?

I think Pavel references to these lines...

/*
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with this program; if not, write to the Free Software
 *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 */

You should at least add a line like "This file is licensed under the terms of 
the GPL v2 license (or any later version).".
-- 
Regards,
Chris

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]