From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 3/3] KVM: Expose MSRs to userspace Date: Fri, 17 Nov 2006 08:06:02 +0000 Message-ID: <20061117080602.GA32211@infradead.org> References: <455CA70C.9060307@qumranet.com> <20061116180422.0CC9325015E@cleopatra.q> <200611162008.48931.arnd@arndb.de> <455CB93E.4090309@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, akpm-3NddpPZAyC0@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, uril-atKUWr5tajBWk0Htik3J/w@public.gmane.org Return-path: To: Avi Kivity Content-Disposition: inline In-Reply-To: <455CB93E.4090309-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, Nov 16, 2006 at 09:17:18PM +0200, Avi Kivity wrote: > Heh. That was the original implementation by Uri. I felt that was > wrong because _IOW() encodes the size in the ioctl number, bit the > actual size is different. That really shouldn't be a problem. After all the pointer approach doesn't encode the transfered size either. Given that the variable sized array gives a much cleaner interface you should use it. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV