From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 19/38] KVM: Make __set_efer() an arch operation
Date: Mon, 27 Nov 2006 13:39:44 +0000
Message-ID: <20061127133944.GA4155@infradead.org>
References: <456AD5C6.1090406@qumranet.com> <20061127122938.0518325015E@cleopatra.q>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	akpm@osdl.org
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1758204AbWK0NkT@vger.kernel.org>
To: Avi Kivity <avi@qumranet.com>
Content-Disposition: inline
In-Reply-To: <20061127122938.0518325015E@cleopatra.q>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Mon, Nov 27, 2006 at 12:29:38PM -0000, Avi Kivity wrote:
>  #ifdef __x86_64__
> -	__set_efer(vcpu, sregs->efer);
> +	kvm_arch_ops->set_efer(vcpu, sregs->efer);
>  #endif

I think it would be much better to make ->set_efer a noop for 32bit,
and have different operation vectors for 32 vs 64 bit.

>  #ifdef __x86_64__
> -	__set_efer(vcpu, 0);
> +	vmx_set_efer(vcpu, 0);
>  #endif

Similarly vmx_set_efer should just become a noop on 32bit.