public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
To: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: [patch] KVM: fix vcpu_clear() bug
Date: Tue, 30 Jan 2007 10:01:55 +0100	[thread overview]
Message-ID: <20070130090155.GA18469@elte.hu> (raw)

Subject: [patch] KVM: fix vcpu_clear() bug
From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>

if vcpu_clear() is called on a not yet run vcpu then vcpu->cpu will be 
-1. Check this case and dont call smp_call_function_single(-1).

this patch fixes the crash i reported earlier and -trunk now works fine 
on a 32-bit SMP host.

Signed-off-by: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
---
 drivers/kvm/vmx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/kvm/vmx.c
===================================================================
--- linux.orig/drivers/kvm/vmx.c
+++ linux/drivers/kvm/vmx.c
@@ -127,7 +127,7 @@ static void __vcpu_clear(void *arg)
 
 static void vcpu_clear(struct kvm_vcpu *vcpu)
 {
-	if (vcpu->cpu != raw_smp_processor_id())
+	if (vcpu->cpu != raw_smp_processor_id() && vcpu->cpu != -1)
 		smp_call_function_single(vcpu->cpu, __vcpu_clear, vcpu, 0, 1);
 	else
 		__vcpu_clear(vcpu);

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

             reply	other threads:[~2007-01-30  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-30  9:01 Ingo Molnar [this message]
     [not found] ` <20070130090155.GA18469-X9Un+BFzKDI@public.gmane.org>
2007-01-30 12:58   ` [patch] KVM: fix vcpu_clear() bug Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070130090155.GA18469@elte.hu \
    --to=mingo-x9un+bfzkdi@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox