From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: [patch] KVM: fix vcpu_clear() bug Date: Tue, 30 Jan 2007 10:01:55 +0100 Message-ID: <20070130090155.GA18469@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-devel Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Subject: [patch] KVM: fix vcpu_clear() bug From: Ingo Molnar if vcpu_clear() is called on a not yet run vcpu then vcpu->cpu will be -1. Check this case and dont call smp_call_function_single(-1). this patch fixes the crash i reported earlier and -trunk now works fine on a 32-bit SMP host. Signed-off-by: Ingo Molnar --- drivers/kvm/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/kvm/vmx.c =================================================================== --- linux.orig/drivers/kvm/vmx.c +++ linux/drivers/kvm/vmx.c @@ -127,7 +127,7 @@ static void __vcpu_clear(void *arg) static void vcpu_clear(struct kvm_vcpu *vcpu) { - if (vcpu->cpu != raw_smp_processor_id()) + if (vcpu->cpu != raw_smp_processor_id() && vcpu->cpu != -1) smp_call_function_single(vcpu->cpu, __vcpu_clear, vcpu, 0, 1); else __vcpu_clear(vcpu); ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV