public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [kvm-commits] kvm: add host hypercall support for vmx (rev 4374)
Date: Thu, 1 Feb 2007 16:04:57 +0200	[thread overview]
Message-ID: <20070201140457.GA15992@rhun.haifa.ibm.com> (raw)
In-Reply-To: <45C1E641.9060203-atKUWr5tajBWk0Htik3J/w@public.gmane.org>

On Thu, Feb 01, 2007 at 03:08:17PM +0200, Avi Kivity wrote:

> >I noticed that the svm 'vmcall_interception' doesn't set
> >kvm_run->exit_reason - is the setting here superflous or needed?  and
> >if it's needed, is it also needed in svm?
> >  
> 
> A 'return 1' means there won't be an exit to userspace, so kvm_run
> won't be used at all.  So the assignment here is superfluous -
> probably a debug artifact.

Thanks for the explanation. I notice it's already gone in the trunk so
no cleanup patch :_)

Cheers,
Muli

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  parent reply	other threads:[~2007-02-01 14:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070201122904.77002A0014@il.qumranet.com>
     [not found] ` <20070201122904.77002A0014-LjA0eNSCdXrQnzwC+xcbyw@public.gmane.org>
2007-02-01 13:01   ` [kvm-commits] kvm: add host hypercall support for vmx (rev 4374) Muli Ben-Yehuda
     [not found]     ` <20070201130116.GA1100-WD1JZD8MxeCTrf4lBMg6DdBPR1lH4CV8@public.gmane.org>
2007-02-01 13:08       ` Avi Kivity
     [not found]         ` <45C1E641.9060203-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-02-01 14:04           ` Muli Ben-Yehuda [this message]
     [not found]             ` <20070201140457.GA15992-WD1JZD8MxeCTrf4lBMg6DdBPR1lH4CV8@public.gmane.org>
2007-02-01 14:07               ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070201140457.GA15992@rhun.haifa.ibm.com \
    --to=muli-7z/5bgajwgfqt0dzr+alfa@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox