Re: [PATCH] kvm compat patch

[Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>]

On Sun, Feb 04, 2007 at 11:35:41AM +0200, Avi Kivity wrote:
> Markus Rechberger wrote:
> > This patch fixes the mutex, page and kzalloc problems with older kernels.
> >
> > Signed-off-by: Markus Rechberger <markus.rechberger-5C7GfCeVMHo@public.gmane.org>
> >
> >   
> 
> The page_private() and kzalloc() stuff looks good, I can apply it.  But:
> 
> > Index: kvm.h
> > ===================================================================
> > --- kvm.h	(revision 4381)
> > +++ kvm.h	(working copy)
> > @@ -8,7 +8,9 @@
> >  
> >  #include <linux/types.h>
> >  #include <linux/list.h>
> > +#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,15)
> >  #include <linux/mutex.h>
> > +#endif
> >   
> 
> Checks on kernel version are (usually) not accepted in mainline.  I
> think I can cook up some Makefile magic to work around the #include
> though.

They're never accepted. They might slip through the cracks if no one
reviews the patch thoroughly enough.

Cheers,
Muli

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642