From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: [PATCH] kvm compat patch Date: Sun, 4 Feb 2007 11:41:59 +0200 Message-ID: <20070204094159.GG3570@rhun.ibm.com> References: <45C29834.4020107@amd.com> <45C5A8ED.2010402@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Markus Rechberger To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <45C5A8ED.2010402-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Sun, Feb 04, 2007 at 11:35:41AM +0200, Avi Kivity wrote: > Markus Rechberger wrote: > > This patch fixes the mutex, page and kzalloc problems with older kernels. > > > > Signed-off-by: Markus Rechberger > > > > > > The page_private() and kzalloc() stuff looks good, I can apply it. But: > > > Index: kvm.h > > =================================================================== > > --- kvm.h (revision 4381) > > +++ kvm.h (working copy) > > @@ -8,7 +8,9 @@ > > > > #include > > #include > > +#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,15) > > #include > > +#endif > > > > Checks on kernel version are (usually) not accepted in mainline. I > think I can cook up some Makefile magic to work around the #include > though. They're never accepted. They might slip through the cracks if no one reviews the patch thoroughly enough. Cheers, Muli ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642