public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>
To: "richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: patch to respect kerneldir when building kernel modules
Date: Tue, 6 Feb 2007 08:51:24 +0200	[thread overview]
Message-ID: <20070206065124.GJ3621@rhun.ibm.com> (raw)
In-Reply-To: <2e59e6970702052201y61a7c71bvac5b35cd97fea410-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Tue, Feb 06, 2007 at 12:01:20AM -0600, richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> On 2/5/07, richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >Currently the kerneldir option to configure is ignored by the 
> >kernel/Makefile
> >
> >This patch fixes that, so you can build modules for your new kernel
> >before booting with it.
> >
> 
> I'd put the line in the wrong place, this is better.

I prefer this version which I sent a couple of days ago:

If the user specifies kerneldir, use it.

Without the patch:

muli@cluwyn:~/kvm/hg$ ./configure --qemu-cc=gcc-3.4 --kerneldir=/home/muli/iommu/calgary/obj.linux/
[snip]
muli@cluwyn:~/kvm/hg$ make
make -C kernel
make[1]: Entering directory `/home/muli/kvm/hg/kernel'
make -C /lib/modules/2.6.17-2-amd64/build M=`pwd` "$@" <=======

With the patch:

muli@cluwyn:~/kvm/hg$ ./configure --qemu-cc=gcc-3.4 --kerneldir=/home/muli/iommu/calgary/obj.linux/
[snip]
muli@cluwyn:~/kvm/hg$ make
make -C kernel
make[1]: Entering directory `/home/muli/kvm/hg/kernel'
make -C /home/muli/iommu/calgary/obj.linux M=`pwd` "$@" <======

To support building directly from kernel/, we don't complain if we
can't find config.mak.

Signed-off-by: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>

diff -r 0df0a31d8154 kernel/Makefile
--- a/kernel/Makefile	Sun Feb 04 08:38:53 2007 +0000
+++ b/kernel/Makefile	Sun Feb 04 12:30:53 2007 +0200
@@ -1,4 +1,6 @@ KERNELDIR := /lib/modules/$(shell uname 
-KERNELDIR := /lib/modules/$(shell uname -r)/build
+-include ../config.mak
+
+KERNELDIR ?= /lib/modules/$(shell uname -r)/build
 KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR))
 
 DESTDIR=

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  parent reply	other threads:[~2007-02-06  6:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06  5:32 patch to respect kerneldir when building kernel modules richardvoigt-Re5JQEeQqe8AvxtiuMwx3w
     [not found] ` <2e59e6970702052132l33612315h1d2310272822ee83-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-02-06  6:01   ` richardvoigt-Re5JQEeQqe8AvxtiuMwx3w
     [not found]     ` <2e59e6970702052201y61a7c71bvac5b35cd97fea410-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-02-06  6:51       ` Muli Ben-Yehuda [this message]
     [not found]         ` <20070206065124.GJ3621-k73YwwB0fHlWk0Htik3J/w@public.gmane.org>
2007-02-06  8:12           ` patch to respect kerneldir when building kernelmodules Dor Laor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070206065124.GJ3621@rhun.ibm.com \
    --to=muli-7z/5bgajwgfqt0dzr+alfa@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox