patch to respect kerneldir when building kernel modules

patch to respect kerneldir when building kernel modules

[richardvoigt-Re5JQEeQqe8AvxtiuMwx3w]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

Currently the kerneldir option to configure is ignored by the kernel/Makefile

This patch fixes that, so you can build modules for your new kernel
before booting with it.

[-- Attachment #2: kvm-should-respect-configured-kerneldir.patch --]
[-- Type: application/octet-stream, Size: 291 bytes --]

Index: kernel/Makefile
===================================================================
--- kernel/Makefile	(revision 4385)
+++ kernel/Makefile	(working copy)
@@ -5,6 +5,8 @@
 
 INSTALLDIR = $(patsubst %/build,%/extra,$(KERNELDIR))
 
+include ../config.mak
+
 rpmrelease = devel
 
 all::

[-- Attachment #3: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: patch to respect kerneldir when building kernel modules

[richardvoigt-Re5JQEeQqe8AvxtiuMwx3w]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

On 2/5/07, richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Currently the kerneldir option to configure is ignored by the kernel/Makefile
>
> This patch fixes that, so you can build modules for your new kernel
> before booting with it.
>
>

I'd put the line in the wrong place, this is better.

[-- Attachment #2: kvm-should-respect-configured-kerneldir.patch --]
[-- Type: application/octet-stream, Size: 294 bytes --]

Index: kernel/Makefile
===================================================================
--- kernel/Makefile	(revision 4385)
+++ kernel/Makefile	(working copy)
@@ -3,6 +3,8 @@
 
 DESTDIR=
 
+include ../config.mak
+
 INSTALLDIR = $(patsubst %/build,%/extra,$(KERNELDIR))
 
 rpmrelease = devel

[-- Attachment #3: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: patch to respect kerneldir when building kernel modules

[Muli Ben-Yehuda]

On Tue, Feb 06, 2007 at 12:01:20AM -0600, richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> On 2/5/07, richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >Currently the kerneldir option to configure is ignored by the 
> >kernel/Makefile
> >
> >This patch fixes that, so you can build modules for your new kernel
> >before booting with it.
> >
> 
> I'd put the line in the wrong place, this is better.

I prefer this version which I sent a couple of days ago:

If the user specifies kerneldir, use it.

Without the patch:

muli@cluwyn:~/kvm/hg$ ./configure --qemu-cc=gcc-3.4 --kerneldir=/home/muli/iommu/calgary/obj.linux/
[snip]
muli@cluwyn:~/kvm/hg$ make
make -C kernel
make[1]: Entering directory `/home/muli/kvm/hg/kernel'
make -C /lib/modules/2.6.17-2-amd64/build M=`pwd` "$@" <=======

With the patch:

muli@cluwyn:~/kvm/hg$ ./configure --qemu-cc=gcc-3.4 --kerneldir=/home/muli/iommu/calgary/obj.linux/
[snip]
muli@cluwyn:~/kvm/hg$ make
make -C kernel
make[1]: Entering directory `/home/muli/kvm/hg/kernel'
make -C /home/muli/iommu/calgary/obj.linux M=`pwd` "$@" <======

To support building directly from kernel/, we don't complain if we
can't find config.mak.

Signed-off-by: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>

diff -r 0df0a31d8154 kernel/Makefile
--- a/kernel/Makefile	Sun Feb 04 08:38:53 2007 +0000
+++ b/kernel/Makefile	Sun Feb 04 12:30:53 2007 +0200
@@ -1,4 +1,6 @@ KERNELDIR := /lib/modules/$(shell uname 
-KERNELDIR := /lib/modules/$(shell uname -r)/build
+-include ../config.mak
+
+KERNELDIR ?= /lib/modules/$(shell uname -r)/build
 KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR))
 
 DESTDIR=

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: patch to respect kerneldir when building kernelmodules

[Dor Laor]

Thanks guys, I applied Muli's patch that also optionally assigns the
kerneldir.
>
>On Tue, Feb 06, 2007 at 12:01:20AM -0600, richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>> On 2/5/07, richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <richardvoigt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> >Currently the kerneldir option to configure is ignored by the
>> >kernel/Makefile
>> >
>> >This patch fixes that, so you can build modules for your new kernel
>> >before booting with it.
>> >
>>
>> I'd put the line in the wrong place, this is better.
>
>I prefer this version which I sent a couple of days ago:
>
>If the user specifies kerneldir, use it.
>
>Without the patch:
>
>muli@cluwyn:~/kvm/hg$ ./configure --qemu-cc=gcc-3.4 --
>kerneldir=/home/muli/iommu/calgary/obj.linux/
>[snip]
>muli@cluwyn:~/kvm/hg$ make
>make -C kernel
>make[1]: Entering directory `/home/muli/kvm/hg/kernel'
>make -C /lib/modules/2.6.17-2-amd64/build M=`pwd` "$@" <=======
>
>With the patch:
>
>muli@cluwyn:~/kvm/hg$ ./configure --qemu-cc=gcc-3.4 --
>kerneldir=/home/muli/iommu/calgary/obj.linux/
>[snip]
>muli@cluwyn:~/kvm/hg$ make
>make -C kernel
>make[1]: Entering directory `/home/muli/kvm/hg/kernel'
>make -C /home/muli/iommu/calgary/obj.linux M=`pwd` "$@" <======
>
>To support building directly from kernel/, we don't complain if we
>can't find config.mak.
>
>Signed-off-by: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>
>
>diff -r 0df0a31d8154 kernel/Makefile
>--- a/kernel/Makefile	Sun Feb 04 08:38:53 2007 +0000
>+++ b/kernel/Makefile	Sun Feb 04 12:30:53 2007 +0200
>@@ -1,4 +1,6 @@ KERNELDIR := /lib/modules/$(shell uname
>-KERNELDIR := /lib/modules/$(shell uname -r)/build
>+-include ../config.mak
>+
>+KERNELDIR ?= /lib/modules/$(shell uname -r)/build
> KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR))
>
> DESTDIR=
>
>-----------------------------------------------------------------------
--
>Using Tomcat but need to do more? Need to support web services,
security?
>Get stuff done quickly with pre-integrated technology to make your job
>easier.
>Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
>http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=12164
2
>_______________________________________________
>kvm-devel mailing list
>kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>https://lists.sourceforge.net/lists/listinfo/kvm-devel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642