public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>
To: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Cc: Pelle <Pelle-5JapdU7xTciEVqv0pETR8A@public.gmane.org>
Subject: [PATCH] restore previous KERNELDIR behavior
Date: Sun, 11 Feb 2007 19:33:26 +0200	[thread overview]
Message-ID: <20070211173326.GC3513@rhun.ibm.com> (raw)

My patch to fix the --kerneldir option to configure caused a subtle
change in behavior when --kerneldir wasn't specified. Previously,
kernel/Makefile would set KERNELDIR to /lib/modules/xxx. The fix
caused it to be set to $(readlink -f /lib/modules/xxx) (via
config.mak). Normally this wouldn't have made any difference, a
symlink and what it points to are synonymous, but various places rely
on KERNELDIR being of the form /lib/modules/xxx for pattern
substitution. Switch back to the old behavior.

This should fix the issue reported by Omar Khan <okhan-e94Sedi4moU@public.gmane.org> and
Pelle <Pelle-5JapdU7xTciEVqv0pETR8A@public.gmane.org>

Signed-off-by: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>

Index: configure
===================================================================
--- configure	(revision 4414)
+++ configure	(working copy)
@@ -94,7 +94,7 @@
 
 cat <<EOF > config.mak
 PREFIX=$prefix
-KERNELDIR=$(readlink -f $kerneldir)
+KERNELDIR="$kerneldir"
 WANT_MODULE=$want_module
 EOF
 


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

                 reply	other threads:[~2007-02-11 17:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070211173326.GC3513@rhun.ibm.com \
    --to=muli-7z/5bgajwgfqt0dzr+alfa@public.gmane.org \
    --cc=Pelle-5JapdU7xTciEVqv0pETR8A@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox