From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: [PATCH resend #1] restore previous KERNELDIR behavior Date: Wed, 14 Feb 2007 05:47:59 +0200 Message-ID: <20070214034759.GB461@rhun.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-devel Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org My patch to fix the --kerneldir option to configure caused a subtle change in behavior when --kerneldir wasn't specified. Previously, kernel/Makefile would set KERNELDIR to /lib/modules/xxx. The fix caused it to be set to $(readlink -f /lib/modules/xxx) (via config.mak). Normally this wouldn't have made any difference, a symlink and what it points to are synonymous, but various places rely on KERNELDIR being of the form /lib/modules/xxx for pattern substitution. Switch back to the old behavior. This should fix the issue reported by Omar Khan and Pelle Signed-off-by: Muli Ben-Yehuda Index: configure =================================================================== --- configure (revision 4414) +++ configure (working copy) @@ -94,7 +94,7 @@ cat < config.mak PREFIX=$prefix -KERNELDIR=$(readlink -f $kerneldir) +KERNELDIR="$kerneldir" WANT_MODULE=$want_module EOF ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV