From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: [kvm-commits] kvm: revert r4386 (rev 4422) Date: Wed, 14 Feb 2007 10:30:39 +0200 Message-ID: <20070214083039.GE461@rhun.ibm.com> References: <20070214075713.2D6DC250354@il.qumranet.com> <20070214080623.GD461@rhun.ibm.com> <45D2C78A.4060203@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <45D2C78A.4060203-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Wed, Feb 14, 2007 at 10:25:46AM +0200, Avi Kivity wrote: > Muli Ben-Yehuda wrote: > >On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote: > > > >>kvm: revert r4386 > >> > >>causes breakage, as well as using evil '?=' assignment. > >> > > > >*sigh*, this breaks --kerneldir. > > > >The patch I resent early this morning does the right thing. > > Well, --kerneldir should be fixed without ?= and with testing. What's wrong with '?='? Are we requiring running `configure' in the top level before running 'make' in kernel/? if yes, getting rid of the KERNELDIR assignment in kernel/Makefile is trivial, if not, '?=' expresses the semantics exactly - if KERNELDIR is already set, use that, if not set it to the default. Cheers, Muli ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV