public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: [patch] KVM: mmu.c, change BUG_ON() to WARN_ON()
Date: Mon, 12 Mar 2007 08:44:26 +0100	[thread overview]
Message-ID: <20070312074426.GA13373@elte.hu> (raw)

Subject: [patch] KVM: mmu.c, change BUG_ON() to WARN_ON()
From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>

this triggered for me with the cr3 cache - do not crash the host, just 
warn about the condition. (Given that there is code after the BUG_ON() 
this was the anticipated behavior i suspect.)

Signed-off-by: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>

Index: linux/drivers/kvm/mmu.c
===================================================================
--- linux.orig/drivers/kvm/mmu.c
+++ linux/drivers/kvm/mmu.c
@@ -514,7 +514,7 @@ static void mmu_page_remove_parent_pte(s
 	int i;
 
 	if (!page->multimapped) {
-		BUG_ON(page->parent_pte != parent_pte);
+		WARN_ON(page->parent_pte != parent_pte);
 		page->parent_pte = NULL;
 		return;
 	}

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

             reply	other threads:[~2007-03-12  7:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-12  7:44 Ingo Molnar [this message]
     [not found] ` <20070312074426.GA13373-X9Un+BFzKDI@public.gmane.org>
2007-03-12  7:46   ` [patch] KVM: mmu.c, change BUG_ON() to WARN_ON() Ingo Molnar
2007-03-12  8:27   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070312074426.GA13373@elte.hu \
    --to=mingo-x9un+bfzkdi@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox