From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [patch] KVM: fix hypercall cache/decache Date: Tue, 20 Mar 2007 10:25:10 +0100 Message-ID: <20070320092510.GA28983@elte.hu> References: <20070320085427.GA21948@elte.hu> <45FFA790.7080007@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <45FFA790.7080007-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org * Avi Kivity wrote: > Ingo Molnar wrote: > >Subject: [patch] KVM: fix hypercall cache/decache > >From: Ingo Molnar > > > >a recent change to kvm_hypercall() flipped around the order of > >->cache_regs() and ->decache_regs(), but that is bogus and causes > >ESP/RIP corruption: ->cache_regs() will 'cache' the CPU-side registers > >into the vcpu structure, and ->decache_regs() will sync it back to the > >CPU. > > > >fix this by using the correct order again. > > That's 57d78025d84fb607aa335d015a79b257517aa209 in my tree... ok :) Ingo ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV