From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: kvm repository unification Date: Tue, 20 Mar 2007 20:36:33 +0100 Message-ID: <200703202036.33702.arnd@arndb.de> References: <45FFCFD7.5000107@qumranet.com> <4600049C.7090905@codemonkey.ws> <460005CE.4080406@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <460005CE.4080406-atKUWr5tajBWk0Htik3J/w@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Tuesday 20 March 2007, Avi Kivity wrote: > > I find using a patch queue useful though for submitting things = > > upstream. =A0A good example is our QEMU changes. =A0It's a real pain to = > > break apart the SVN history into individual patches. > = > Why not just extract diffs with 'svn diff'? =A0That's what I did/do. Just a few random thoughts on this: - if you have multiple changesets in svn that you want to submit as a single patch, it's useful to only have to do the folding once. - Having the changeset as a patch means that multiple developers can add their Acked-by: and Signed-off-by: by editing the description in the patch file, while you can't easily change an existing changeset comment. E.g. I require everyone with write access to add their own Signed-off-by:, while I add mine when I look at the patches I want to send out. - When a developer checks in a new changeset, I found that often there are formal problems in it, e.g. the comment doesn't follow the rules for kernel commits, or there is some coding style problem. In a patch file, you can trivially fix that. Arnd <>< ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3DDE= VDEV