Re: [PATCH] SVM: enable LBRV virtualization if available

["Joerg Roedel" <joerg.roedel-5C7GfCeVMHo@public.gmane.org>]

On Fri, Mar 30, 2007 at 05:04:29PM +0300, Avi Kivity wrote:
> Joerg Roedel wrote:
> >From: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
> >
> >This patch enables the virtualization of the last branch record MSRs on
> >SVM if this feature is available in hardware. It also introduces a small
> >and simple check feature for specific SVM extensions.
> >  
> 
> >+#define SVM_DEATURE_SVML (1 << 2)
> >  
> 
> FEATURE? DENTURE?

Uh, a typo went in the patch. This must be SVM_FEATURE_SVML.

> >+
> >+#define svm_has(feat) (svm_features & (feat))
> >+
> >  
> 
> I prefer a static inline instead of a function-like macro.

Ok, will remember that in the next patches.

> > unsigned long iopm_base;
> > unsigned long msrpm_base;
> > @@ -68,6 +74,7 @@ struct svm_cpu_data {
> > };
> >  static DEFINE_PER_CPU(struct svm_cpu_data *, svm_data);
> >+static uint32_t svm_features;
> >  
> 
> u32 outside userspace headers.

Is struct svm_cpu_data a userspace data structure. I ask because in a
previous version of the patch the svm_features variable was part of that
struct. Thats why I used this type.

> Anyway I fixed these up and applied.

Thanks,
Joerg

-- 
Joerg Roedel
Operating System Research Center
AMD Saxony LLC & Co. KG



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV