Re: QEMU PIC indirection patch for in-kernel APIC work

Gregory Haskins
2007-04-04T17:51:16Z

>>> On Wed, Apr 4, 2007 at 10:20 AM, in message <4613B438.60107-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>,
Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> wrote:
>
> The devices are already written to take a set_irq function. Instead of
> hijacking the emulated PIC device, I think it would be better if in
> pc.c, we just conditionally created our PIC device that reflected to the
> hypervisor and passed the appropriate function to the emulated hardware.
>

When I first starting looking at the code, I was hoping to do exactly that. But unfortunately it appears as though many devices call pic_set_irq() directly which is why I used the approach I did. Take a look at qemu/hw/rt18139.c for an example.

> Otherwise, to support all the other architectures, there's going to be a
> lot of modifications.

Fully agree, which is why I waited for review before putting in all that work ;)

-Greg