From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
cborntra-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH/RFC 2/2] s390 virtualization interface.
Date: Wed, 2 May 2007 09:25:33 +0100 [thread overview]
Message-ID: <20070502082533.GA23674@infradead.org> (raw)
In-Reply-To: <200705012312.11692.arnd-r2nGTMty4D4@public.gmane.org>
On Tue, May 01, 2007 at 11:12:11PM +0200, Arnd Bergmann wrote:
> Not sure about that point. If you need to do atomic operations on the
> first 32 bits, you shouldn't need to invent your own abstractions for
> those, and it's highly unlikely that the implementation of atomic_t changes.
I disagree. Using an atomic_t in a hardware structure is against all
the abstractions we've built. It's much better to have separate macros
to atomically modify a word in this hardware strcuture, even if they end
up exactly the same as the atomic_ macros - at least this way we clearly
document their intent.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
prev parent reply other threads:[~2007-05-02 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 13:40 [PATCH/RFC 2/2] s390 virtualization interface Carsten Otte
[not found] ` <1177681235.5770.22.camel-WIxn4w2hgUz3YA32ykw5MLlKpX0K8NHHQQ4Iyu8u01E@public.gmane.org>
2007-04-27 15:23 ` Anthony Liguori
[not found] ` <4632155C.8030503-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-04-27 15:45 ` Carsten Otte
2007-04-27 16:53 ` Arnd Bergmann
[not found] ` <200704271853.41523.arnd-r2nGTMty4D4@public.gmane.org>
2007-04-29 8:00 ` Heiko Carstens
[not found] ` <20070429080039.GA8332-5VkHqLvV2o3MbYB6QlFGEg@public.gmane.org>
2007-05-01 21:12 ` Arnd Bergmann
[not found] ` <200705012312.11692.arnd-r2nGTMty4D4@public.gmane.org>
2007-05-02 4:46 ` Avi Kivity
2007-05-02 8:25 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070502082533.GA23674@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=cborntra-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox