From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian =?iso-8859-1?q?Borntr=E4ger?= Subject: Re: [PATCH/RFC 5/9] s390 virtual console for guests Date: Fri, 11 May 2007 21:42:11 +0200 Message-ID: <200705112142.11547.cborntra@de.ibm.com> References: <1178903957.25135.13.camel@cotte.boeblingen.de.ibm.com> <1178904960.25135.32.camel@cotte.boeblingen.de.ibm.com> <4644BD3C.8040901@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Martin Schwidefsky To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: In-Reply-To: <4644BD3C.8040901-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Friday 11 May 2007 21:00, Anthony Liguori wrote: > I think it would be better to use hvc_console as Xen now uses it too. I dont know hvc_console, but I will have a look at it. > Carsten Otte wrote: > > + if (!MACHINE_IS_GUEST) > > + return 0; > > + register_external_interrupt(0x1234, guest_tty_ext_handler); > > > > This is an interesting way to get input data from the console :-) How > many interrupts does s390 support (the x86 only supports 256)? Can you > afford to burn interrupts like this? Is there not a better way to > assign interrupts such that conflict isn't an issue? On s390 we have a 16 bit interrupt code, so we actually have plenty of numbers... But, yes its a very good point, burning interrupts wont work cross-platform. Our patches are prototypes and need rework anyway. Take these patches as discussion contribution in the spirit of release early. :-) cheers Christian ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/