From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH/RFC 5/9] s390 virtual console for guests Date: Tue, 15 May 2007 02:27:34 +0200 Message-ID: <200705150227.34599.arnd@arndb.de> References: <1178903957.25135.13.camel@cotte.boeblingen.de.ibm.com> <200705141848.18996.borntrae@de.ibm.com> <4648A11D.3050607@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Martin Schwidefsky To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: In-Reply-To: <4648A11D.3050607-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Monday 14 May 2007, Anthony Liguori wrote: > It seems like request_irq is roughly the same as = > register_external_interrupt. =A0I suspect that you could get away with = > either patching hvc_console to use register_external_interrupt if = > CONFIG_S390 or perhaps providing a common interface. > = > I suspect that this is going to come up again for sharing other paravirt = > drivers. request_irq() is not a nice interface for s390, but it will probably make sense to convert the two existing users of register_external_interrupt to use that instead, in order to get something that can be shared across architectures for virtual drivers. It basically means extending struct ext_int_info_t to include a name and a void* member that gets passed back to the interrupt handler, and to check for invalid flags passed to request_irq. You might want to show these in /proc/interrupts then as well, as per-interrupt values. Arnd <>< ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/