From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Carstens Subject: Re: [PATCH 4/7] SMP: Implement on_one_cpu() Date: Thu, 24 May 2007 15:36:25 +0200 Message-ID: <20070524133625.GA9863@osiris.ibm.com> References: <1180008615579-git-send-email-avi@qumranet.com> <11800086152009-git-send-email-avi@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lhcs-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <11800086152009-git-send-email-avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, May 24, 2007 at 03:10:12PM +0300, Avi Kivity wrote: > This defines on_one_cpu() which is similar to smp_call_function_single() > except that it works if cpu happens to be the current cpu. Can also be > seen as a complement to on_each_cpu() (which also doesn't treat the > current cpu specially). > > Signed-off-by: Avi Kivity > --- > include/linux/smp.h | 15 +++++++++++++++ > kernel/softirq.c | 24 ++++++++++++++++++++++++ > 2 files changed, 39 insertions(+), 0 deletions(-) > > +/* > + * Call a function on one processor > + */ > +int on_one_cpu(int cpu, void (*func)(void *info), void *info, > + int retry, int wait); > Would you mind renaming that one to simply 'on_cpu'? It's even shorter and clearly everybody will know what its purpose is. Also I doubt we will ever have something like 'on_two_cpus'. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/