From: Jeff Dike <jdike-OPE4K8JWMJJBDgjK7y7TUQ@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] KVM - Fix rmode_tss_base declaration
Date: Fri, 8 Jun 2007 15:44:41 -0400 [thread overview]
Message-ID: <20070608194441.GA8169@c2.user-mode-linux.org> (raw)
In-Reply-To: <4667931C.8070007-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
On Thu, Jun 07, 2007 at 08:09:48AM +0300, Avi Kivity wrote:
> Some extra logic is needed on i386 with >= 4GB. Current code will
> wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not
> the answer since the processor will truncate it back to 32 bits (the
> return value is eventually used as a long in enter_rmode()).
Is it necessary to initialize TR in enter_rmode? I can't see anything
that says it has any meaning in real mode.
And if not, would not the guest be responsible for finding room for the
TSS?
Jeff
--
Work email - jdike at linux dot intel dot com
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-06-08 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 19:19 [PATCH] KVM - Fix rmode_tss_base declaration Jeff Dike
[not found] ` <20070606191925.GA8989-1LLyehjZOUUZWFFyALql+T+iFHGzDt/a@public.gmane.org>
2007-06-07 2:13 ` Li, Xin B
[not found] ` <B30DA1341B0CFA4893EF8A36B40B5C5D013A32CB-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-06-07 3:11 ` Jeff Dike
[not found] ` <20070607031103.GA12462-1LLyehjZOUUZWFFyALql+T+iFHGzDt/a@public.gmane.org>
2007-06-07 5:09 ` Avi Kivity
[not found] ` <4667931C.8070007-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-08 19:44 ` Jeff Dike [this message]
2007-06-10 7:36 ` [kvm-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608194441.GA8169@c2.user-mode-linux.org \
--to=jdike-ope4k8jwmjjbdgjk7y7tuq@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox