From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Dike Subject: Re: [PATCH] KVM - Fix rmode_tss_base declaration Date: Fri, 8 Jun 2007 15:44:41 -0400 Message-ID: <20070608194441.GA8169@c2.user-mode-linux.org> References: <20070606191925.GA8989@c2.user-mode-linux.org> <20070607031103.GA12462@c2.user-mode-linux.org> <4667931C.8070007@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, LKML To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <4667931C.8070007-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, Jun 07, 2007 at 08:09:48AM +0300, Avi Kivity wrote: > Some extra logic is needed on i386 with >= 4GB. Current code will > wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not > the answer since the processor will truncate it back to 32 bits (the > return value is eventually used as a long in enter_rmode()). Is it necessary to initialize TR in enter_rmode? I can't see anything that says it has any meaning in real mode. And if not, would not the guest be responsible for finding room for the TSS? Jeff -- Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/