Re: [PATCH] KVM - Fix rmode_tss_base declaration

Avi Kivity
2007-06-07T05:09:48Z

Jeff Dike wrote:
> On Thu, Jun 07, 2007 at 10:13:42AM +0800, Li, Xin B wrote:
>
>>> -static int rmode_tss_base(struct kvm* kvm)
>>> +static unsigned long rmode_tss_base(struct kvm* kvm)
>>>
>> Should use gpa_t instead.
>>
>
> Right you are, I didn't notice that type.
>
>

Some extra logic is needed on i386 with >= 4GB. Current code will
wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not
the answer since the processor will truncate it back to 32 bits (the
return value is eventually used as a long in enter_rmode()).

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.