From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Jones <davej@redhat.com>
Cc: Adrian Bunk <bunk@stusta.de>,
avi@qumranet.com, linux-kernel@vger.kernel.org,
kvm-devel@lists.sourceforge.net
Subject: Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n
Date: Tue, 12 Jun 2007 15:03:57 -0700 [thread overview]
Message-ID: <20070612150357.1685c622.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070612032224.GA19293@redhat.com>
On Mon, 11 Jun 2007 23:22:24 -0400
Dave Jones <davej@redhat.com> wrote:
> Add -Werror-implicit-function-declaration
> This makes builds fail sooner if something is implicitly defined instead
> of having to wait half an hour for it to fail at the linking stage.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6/Makefile~ 2007-06-04 16:46:24.000000000 -0400
> +++ linux-2.6/Makefile 2007-06-04 16:46:53.000000000 -0400
> @@ -313,7 +313,8 @@ LINUXINCLUDE := -Iinclude \
> CPPFLAGS := -D__KERNEL__ $(LINUXINCLUDE)
>
> CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> - -fno-strict-aliasing -fno-common
> + -fno-strict-aliasing -fno-common \
> + -Werror-implicit-function-declaration
> AFLAGS := -D__ASSEMBLY__
>
> # Read KERNELRELEASE from include/config/kernel.release (if it exists)
This causes the i386 allmodconfig build to fail:
include/linux/uaccess.h: In function 'pagefault_disable':
include/linux/uaccess.h:23: error: implicit declaration of function '__memory_barrier'
I didn't look to see why...
next prev parent reply other threads:[~2007-06-12 22:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070606220313.8f7c1fab.akpm@linux-foundation.org>
2007-06-12 0:07 ` 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n Adrian Bunk
2007-06-12 3:22 ` Dave Jones
2007-06-12 22:03 ` Andrew Morton [this message]
2007-06-12 22:16 ` Dave Jones
2007-06-12 22:43 ` Andrew Morton
2007-06-12 22:48 ` Dave Jones
2007-06-12 22:37 ` Adrian Bunk
2007-06-12 6:00 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612150357.1685c622.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=avi@qumranet.com \
--cc=bunk@stusta.de \
--cc=davej@redhat.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox