From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH][RFC] kvm-scheduler integration
Date: Sun, 8 Jul 2007 15:48:50 +0200 [thread overview]
Message-ID: <20070708134850.GB22911@elte.hu> (raw)
In-Reply-To: <4690E973.7000606-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
* Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
> >>+#ifdef CONFIG_SCHED_KVM
> >>+static __read_mostly struct sched_kvm_hooks kvm_hooks;
> >>+#endif
> >
> >please just add a current->put_vcpu() function pointer instead of
> >this hooks thing.
>
> Won't that increase task_struct (16 bytes on 64-bit) unnecessarily?
> The function pointers are common to all virtual machines.
well, this function pointer could then be reused by other virtual
machines as well, couldnt it? If the task struct overhead is a problem
(it really isnt, and it's dependent on CONFIG_KVM) then we could switch
it around to a notifier-alike mechanism.
Ingo
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-07-08 13:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 12:58 [PATCH][RFC] kvm-scheduler integration Avi Kivity
[not found] ` <11838994974161-git-send-email-avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-08 13:09 ` Ingo Molnar
2007-07-08 13:16 ` Avi Kivity
2007-07-08 13:36 ` Ingo Molnar
2007-07-08 13:35 ` Ingo Molnar
[not found] ` <20070708133539.GA12597-X9Un+BFzKDI@public.gmane.org>
2007-07-08 13:41 ` Avi Kivity
[not found] ` <4690E973.7000606-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-08 13:48 ` Ingo Molnar [this message]
[not found] ` <20070708134850.GB22911-X9Un+BFzKDI@public.gmane.org>
2007-07-08 13:53 ` Avi Kivity
[not found] ` <4690EC47.6060904-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-08 13:59 ` Ingo Molnar
[not found] ` <20070708135905.GA24991-X9Un+BFzKDI@public.gmane.org>
2007-07-08 15:13 ` Avi Kivity
2007-07-10 11:18 ` Avi Kivity
[not found] ` <46936AF2.9010400-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-10 11:30 ` Ingo Molnar
2007-07-08 23:32 ` Rusty Russell
[not found] ` <1183937563.6005.365.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-09 6:39 ` Avi Kivity
[not found] ` <4691D82F.3030401-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-10 1:09 ` Rusty Russell
[not found] ` <1184029745.6005.402.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-10 5:53 ` Avi Kivity
[not found] ` <46931ECB.2060601-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-10 6:47 ` Rusty Russell
[not found] ` <1184050055.6005.523.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-10 7:19 ` Avi Kivity
[not found] ` <469332F3.1000808-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-10 8:01 ` Rusty Russell
[not found] ` <1184054478.6005.555.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2007-07-10 8:24 ` Avi Kivity
2007-07-11 5:50 ` Avi Kivity
2007-07-09 8:50 ` Shaohua Li
[not found] ` <1183971001.4254.3.camel-yAZKuqJtXNMXR+D7ky4Foa2pdiUAq4bhAL8bYrjMMd8@public.gmane.org>
2007-07-09 9:46 ` Avi Kivity
[not found] ` <469203E9.7000109-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-09 10:21 ` Avi Kivity
[not found] ` <p73ir8uzpcx.fsf@bingen.suse.de>
[not found] ` <p73ir8uzpcx.fsf-KvMlXPVkKihbpigZmTR7Iw@public.gmane.org>
2007-07-09 6:41 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070708134850.GB22911@elte.hu \
--to=mingo-x9un+bfzkdi@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox