From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 2/3] i386: use x86_64's desc_def.h Date: 19 Jul 2007 02:00:26 +0200 Message-ID: <20070719000026.GA29650@muc.de> References: <1184743355.10380.112.camel@localhost.localdomain> <1184743422.10380.114.camel@localhost.localdomain> <469E3DA1.3010600@vmware.com> <1184801261.10380.174.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Zachary Amsden , kvm-devel , Andrew Morton , lkml - Kernel Mailing List To: Rusty Russell Return-path: Date: Thu, 19 Jul 2007 02:00:26 +0200 Content-Disposition: inline In-Reply-To: <1184801261.10380.174.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, Jul 19, 2007 at 09:27:41AM +1000, Rusty Russell wrote: > On Wed, 2007-07-18 at 09:19 -0700, Zachary Amsden wrote: > > > +#define GET_CONTENTS(desc) (((desc)->raw32.b >> 10) & 3) > > > +#define GET_WRITABLE(desc) (((desc)->raw32.b >> 9) & 1) > > > > You got rid of the duplicate definitions here, but then added new > > duplicates (GET_CONTENTS / WRITABLE). Can you stick them in desc.h? > > To be honest, I got sick of counting bits at this point, and didn't want > to introduce bugs. Where is 1/ and 3/ ? I got an older version of this patch queued now -Andi ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/