From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Paris Subject: Re: migration with exec giving truncated images Date: Mon, 13 Aug 2007 23:56:59 -0400 Message-ID: <20070814035659.GA10726@jim.sh> References: <1186604569626-git-send-email-jim@jtan.com> <46BB0760.80405@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Uri Lublin Return-path: Content-Disposition: inline In-Reply-To: <46BB0760.80405-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Uri Lublin wrote: > There is still the mystery of different file sizes for different > migration-exec commands, all files are "valid saved image". > It seems to me that some unmodified pages are being marked as dirty, and > are being saved twice (and later loaded twice). > I'm still chasing that. Hi Uri, I looked into this a bit more and it seems that a big piece of migration.c is missing or broken. In migrate_write_buffer, it calls migrate_check_convergence, which returns TRUE if the migration is "almost" complete (dirty pages < 50, or too many iterations through memory). At that point, it then calls migrate_finish -- which finishes writing the current page, but never actually writes the remaining 50 pages (!) Am I missing something? -jim ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/