kvm-37 problem w/ 64-bit division in lapic.c

[Jindrich Makovicka <makovick-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

On Sun, 09 Sep 2007 14:05:13 +0300
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:

> This release merges the pic/lapic/ioapic into mainline.  While some 
> known issues exist, we're now at the point where it's better to get
> some wider exposure rather than keep it alone on a branch.
> 
> Some regressions are expected; please report them as they appear.  A
> new qmeu option -no-kvm-irqchip is available to disable the new
> functionality.

(message seems to get stuck at gmane, sorry if it appears twice
eventually)

My experience so far:

On 32-bit Intel host, lapic fails to link due to missing 64bit
division. I tried the attached patch to fix the build, but Windows
XP froze before showing the booting screen. With -no-kvm-irqchip
they work, except the IE plugins like Flash & Java, which are broken
since kvm-29. With -no-kvm, qemu-system-x86_64 segfaults immediately.

Regards,
-- 
Jindrich Makovicka

[-- Attachment #2: lapic.c.diff --]
[-- Type: text/x-patch, Size: 589 bytes --]

--- lapic.c~	2007-09-09 12:51:09.000000000 +0200
+++ lapic.c	2007-09-09 16:12:38.000000000 +0200
@@ -31,6 +31,7 @@
 #include <asm/current.h>
 #include <asm/apicdef.h>
 #include <asm/atomic.h>
+#include <asm/div64.h>
 #include "irq.h"
 
 #define PRId64 "d"
@@ -511,8 +512,8 @@
 	} else
 		passed = ktime_sub(now, apic->timer.last_update);
 
-	counter_passed = ktime_to_ns(passed) /
-	    (APIC_BUS_CYCLE_NS * apic->timer.divide_count);
+	counter_passed = div64_64(ktime_to_ns(passed),
+				  (APIC_BUS_CYCLE_NS * apic->timer.divide_count));
 	tmcct -= counter_passed;
 
 	if (tmcct <= 0) {

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel