Re: [PATCH 3/3] virtio module alias support

[Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]

On Tue, Sep 25, 2007 at 10:50:04AM +1000, Rusty Russell wrote:
> On Mon, 2007-09-24 at 09:02 -0700, Greg KH wrote:
> > On Mon, Sep 24, 2007 at 07:16:34PM +1000, Rusty Russell wrote:
> > > This adds the logic to convert the virtio ids into module aliases, and
> > > includes a modalias entry in sysfs.
> > > 
> > > Unfortunately this does not seem sufficient to have the module
> > > autoprobed at startup on my Ubuntu system.  Greg?  Am I missing some
> > > udev magic?
> > 
> > You also need to pass the MODINFO environment variable to the hotplug
> > call so that udev can pick it up.
> > 
> > hope this helps,
> 
> Well, I finally decoded this as follows:
> 
>         You need to implement the bus_type.uevent hook, and use
>         add_uevent_var() to add a "MODALIAS=virtio:..." var.  See
>         drivers/pci/hotplug.c.

Ah, sorry, thanks for intrepreting it properly :)

> Not sure why I need the modalias here when it's in sysfs.  But, it
> works.

udev does not read from sysfs anymore, it just uses the environment
variables.  It's faster and race-free that way.

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/