public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
To: Jim Paris <jim-XrPbb/hENzg@public.gmane.org>
Cc: kvm-devel
	<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	Discussion about the virtualization on CentOS
	<centos-virt-IFYaIzF+flcdnm+yROfE0A@public.gmane.org>
Subject: Re: [RFC] let kvm be compiled with gcc4 and prevent users to shoot themselves in the foot while doing so (was Re: [ kvm-Bugs-1807620 ]	KVM's	--disable-gcc-check	doesn't work)
Date: Mon, 8 Oct 2007 01:15:36 -0500	[thread overview]
Message-ID: <20071008061536.GB26380@tapir> (raw)
In-Reply-To: <20071007221827.GA25232-lSbMZ+N7itA@public.gmane.org>

On Sun, Oct 07, 2007 at 06:18:27PM -0400, Jim Paris wrote:
> > +  if test $check_gcc = "no" ; then
> > +    if gcc -v 2>&1 | grep -q 'gcc *version *4\.[0-3]\.[0-9]'; then
> > +      echo "#define USE_GCC4 1" >> $config_h
> > +    fi
> > +  fi
> 
> Something like
> 
> #if __GNUC__ >= 4
> 
> in the code would be simpler.

really good idea; and also as a side effect makes the patches independent as
there is no need to have that qemu's configure glue anymore.

Carlo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

  parent reply	other threads:[~2007-10-08  6:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-04 16:25 [ kvm-Bugs-1807620 ] KVM's --disable-gcc-check doesn't work SourceForge.net
     [not found] ` <E1IdTWB-0003Uo-Dv-fsxqSYOXIJgGKePtCzJsP6QD96bmaF075NbjCUgZEJk@public.gmane.org>
2007-10-04 16:33   ` Farkas Levente
     [not found]     ` <470515DA.9080606-lWVWdrzSO4GHXe+LvDLADg@public.gmane.org>
2007-10-04 16:54       ` Gregory Haskins
     [not found]         ` <1191516896.5019.83.camel-5CR4LY5GPkvLDviKLk5550HKjMygAv58XqFh9Ls21Oc@public.gmane.org>
2007-10-04 17:27           ` Farkas Levente
     [not found]             ` <47052269.80501-lWVWdrzSO4GHXe+LvDLADg@public.gmane.org>
2007-10-04 17:42               ` Gregory Haskins
     [not found]                 ` <1191519749.5019.99.camel-5CR4LY5GPkvLDviKLk5550HKjMygAv58XqFh9Ls21Oc@public.gmane.org>
2007-10-04 19:49                   ` Farkas Levente
     [not found]                     ` <470543AC.50901-lWVWdrzSO4GHXe+LvDLADg@public.gmane.org>
2007-10-04 20:39                       ` Gregory Haskins
     [not found]                         ` <1191530370.5019.108.camel-5CR4LY5GPkvLDviKLk5550HKjMygAv58XqFh9Ls21Oc@public.gmane.org>
2007-10-07 21:20                           ` [RFC] let kvm be compiled with gcc4 and prevent users to shoot themselves in the foot while doing so (was Re: [ kvm-Bugs-1807620 ] KVM's --disable-gcc-check doesn't work) Carlo Marcelo Arenas Belon
2007-10-07 22:18                             ` Jim Paris
     [not found]                               ` <20071007221827.GA25232-lSbMZ+N7itA@public.gmane.org>
2007-10-08  6:15                                 ` Carlo Marcelo Arenas Belon [this message]
2007-10-05 11:41                       ` [ kvm-Bugs-1807620 ] KVM's --disable-gcc-check doesn't work Avi Kivity
2007-10-05 16:54                   ` Bernhard Kaindl
2007-10-05 17:00           ` Anthony Liguori
2007-10-08 15:43   ` [ kvm-Bugs-1807620 ] KVM's --disable-gcc-check doesn'twork Itamar Heim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071008061536.GB26380@tapir \
    --to=carenas-kledwsohozojb6fo7hg9ng@public.gmane.org \
    --cc=centos-virt-IFYaIzF+flcdnm+yROfE0A@public.gmane.org \
    --cc=jim-XrPbb/hENzg@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox