From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlo Marcelo Arenas Belon Subject: Re: [RFC] let kvm be compiled with gcc4 and prevent users to shoot themselves in the foot while doing so (was Re: [ kvm-Bugs-1807620 ] KVM's --disable-gcc-check doesn't work) Date: Mon, 8 Oct 2007 01:15:36 -0500 Message-ID: <20071008061536.GB26380@tapir> References: <470515DA.9080606@bppiac.hu> <1191516896.5019.83.camel@ghaskins-t60p.haskins.net> <47052269.80501@bppiac.hu> <1191519749.5019.99.camel@ghaskins-t60p.haskins.net> <470543AC.50901@bppiac.hu> <1191530370.5019.108.camel@ghaskins-t60p.haskins.net> <20071007212054.GA26380@tapir> <20071007221827.GA25232@jim.sh> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Discussion about the virtualization on CentOS To: Jim Paris Return-path: Content-Disposition: inline In-Reply-To: <20071007221827.GA25232-lSbMZ+N7itA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Sun, Oct 07, 2007 at 06:18:27PM -0400, Jim Paris wrote: > > + if test $check_gcc = "no" ; then > > + if gcc -v 2>&1 | grep -q 'gcc *version *4\.[0-3]\.[0-9]'; then > > + echo "#define USE_GCC4 1" >> $config_h > > + fi > > + fi > > Something like > > #if __GNUC__ >= 4 > > in the code would be simpler. really good idea; and also as a side effect makes the patches independent as there is no need to have that qemu's configure glue anymore. Carlo ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/