From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlo Marcelo Arenas Belon Subject: Re: [PATCH] Allow users to override compiler checks for gcc3 by only using --disable-gcc-check as done in qemu Date: Tue, 9 Oct 2007 01:02:02 -0500 Message-ID: <20071009060202.GA8418@tapir> References: <20071008152937.GA2137@tapir> <470A5982.5080606@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <470A5982.5080606-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Mon, Oct 08, 2007 at 06:23:30PM +0200, Avi Kivity wrote: > Carlo Marcelo Arenas Belon wrote: > > > > If the qemu-cc option is not used but disable-gcc-check is requested then > > assume that the default system gcc should be used (chosen by name) > > > > This patch fixes sourceforge bug id 1807620 > > This deviates from normal qemu, no? I think qemu-s --disable-gcc-check > doesn't imply anything about the compiler. --disable-gcc-check in qemu's configure just shortcuts all the tests to validate that the compiler to be used is gcc-3.x and that defaults to "gcc" in the case of kvm's configure, using "gcc" as the default compiler will be the case if : 1) the user didn't provide his own --qemu-cc preference 2) gcc-3.x couldn't be found when searching by name in /usr/bin/ and which is the expected behavior on qemu when --disable-gcc-check is used. Carlo PS. ideally host_cc should be by default "${CC}" if defined but using "gcc" is what qemu's configure does so did the same for consistency reasons ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/