[RFC] modular dependencies for kvm's qemu

[Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>]

Greetings,

kvm's configure calls qemu's configure with --enable-alsa, making the
existence and use of alsa a dependency; with the import of the latest CVS
qemu, a similar implicit dependency has been added for gnutls (required for
TLS support for qemu's vnc server).

the following proposed patch (which is a combined patch from a 2 patch series)
allows kvm's configure to enable alsa or disable vnc tls conditionally.

I am curious if the approach taken for alsa (which is the one that fits what
qemu's configure allows for this case) is acceptable or not, as it will change
the dependency on alsa from being required by default to optional and unless 
--enable-alsa is used.

Carlo
---
--- kvm-46/configure	2007-10-09 11:43:12.000000000 -0700
+++ kvm-46/configure	2007-10-16 01:40:32.000000000 -0700
@@ -16,6 +16,8 @@
 	    --with-patched-kernel  don't use external module
 	    --kerneldir=DIR        kernel build directory ($kerneldir)
 	    --qemu-cc="$qemu_cc"   compiler for qemu (needs gcc3.x) ($qemu_cc)
+	    --enable-alsa          enable alsa support for qemu
+	    --disable-vnc-tls	   disable vnc tls support for qemu
 	    --disable-gcc-check    don't insist on gcc-3.x
                                    - this will break running without kvm
 EOF
@@ -50,6 +52,12 @@
 	--qemu-cc)
 	    qemu_cc="$arg"
 	    ;;
+	--enable-alsa)
+	    enable_alsa=1
+	    ;;
+	--disable-vnc-tls)
+	    disable_vnc_tls=1
+	    ;;
 	--disable-gcc-check)
 	    disable_gcc_check=1
 	    ;;
@@ -85,7 +93,8 @@
     --disable-kqemu --extra-cflags="-I $PWD/../user" \
     --extra-ldflags="-L $PWD/../user" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
-    --enable-alsa \
+    ${enable_alsa:+"--enable-alsa"} \
+    ${disable_vnc_tls:+"--disable-vnc-tls"} \
     ${disable_gcc_check:+"--disable-gcc-check"} \
     --prefix="$prefix"
 )

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/