Re: [RFC] passthrough for configure options to qemu

[Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>]

On Sun, Oct 21, 2007 at 01:25:34PM +0200, Avi Kivity wrote:
>
> Why not call qemu's ./configure to get the help text?

can be done, I discarded it originally though as it seems pretty hacky as it 
needs the list to be reformatted and filtered further as not all options are 
relevant and some conflict with the ones that the final configure call for qemu
is going to use, requiring assumptions about qemu which seem to defeat the
principle of separation that a passthrough provides.

if it wouldn't be that we rely in the --disable-gcc-check description to warn
users that having kvm crash is expected if not using kvm, I'd say is probably
better to remove all qemu options from kvm's configure usage() at all

> >@@ -111,13 +102,10 @@ fi
> >     --disable-kqemu --extra-cflags="-I $PWD/../user $qemu_cflags" \
> >     --extra-ldflags="-L $PWD/../user $qemu_ldflags" \
> >     --enable-kvm --kernel-path="$libkvm_kerneldir" \
> >-    ${enable_alsa:+"--enable-alsa"} \
> >-    ${disable_vnc_tls:+"--disable-vnc-tls"} \
> >-    ${disable_gcc_check:+"--disable-gcc-check"} \
> >     --prefix="$prefix" \
> >     ${qemu_cc:+"--cc=$qemu_cc"} \
> >     ${cross_prefix:+"--cross-prefix=$cross_prefix"} \
> >-    ${cross_prefix:+"--cpu=$arch"}
> >+    ${cross_prefix:+"--cpu=$arch"} $qemu_conf
> > )
> 
> Is it possible in case of a failure due to an unrecognized option to 
> call out usage() instead of qemu's?

not sure what you mean, but qemu's configure ignores any unrecognized options
so it won't fail.

Carlo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/