From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] Define smp_call_function_mask() on uniprocessor builds Date: Wed, 24 Oct 2007 07:43:54 -0700 Message-ID: <20071024074354.9edd4cee.akpm@linux-foundation.org> References: <11932158852325-git-send-email-avi@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, bunk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Linus Torvalds , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <11932158852325-git-send-email-avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Wed, 24 Oct 2007 10:51:25 +0200 Avi Kivity wrote: > Rather than #ifdef users of smp_call_function_mask(), define it as an > empty macro to avoid build errors. The function explicitly prohibits > callers from specifying the current cpu, so nothing needs to be done. > > This unbreaks uniprocessor KVM builds. > > Signed-off-by: Avi Kivity > > diff --git a/include/linux/smp.h b/include/linux/smp.h > index 259a13c..24e2e31 100644 > --- a/include/linux/smp.h > +++ b/include/linux/smp.h > @@ -108,6 +108,9 @@ static inline void smp_send_reschedule(int cpu) { } > 0; \ > }) > > +#define smp_call_function_mask(mask, func, info, wait) \ > + do { (void)(mask); (void)(func); (void)(info); (void)(wait); } while (0) > + > #endif /* !SMP */ > > /* The real smp_call_function_mask() returns int, so this version should do so also. An inlined C function will provide the needed references to the arguments - no need for those funny (void) thingies. And it will provide typechecking. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/