From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] raise tsc clocksource rating Date: Tue, 30 Oct 2007 00:21:40 +0100 Message-ID: <20071029232140.GA10518@elte.hu> References: <11936994092607-git-send-email-gcosta@redhat.com> <1193697734.9793.86.camel@bodhitayantram.eng.vmware.com> <20071029224852.GA27547@elte.hu> <47266431.1010500@goop.org> <20071029225528.GA31293@elte.hu> <47266A00.4040408@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Zachary Amsden , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Dan Hecht , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Avi Kivity , Glauber de Oliveira Costa , Glauber de Oliveira Costa , Garrett Smith To: Jeremy Fitzhardinge Return-path: Content-Disposition: inline In-Reply-To: <47266A00.4040408-TSDbQ3PG+2Y@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org * Jeremy Fitzhardinge wrote: > Ingo Molnar wrote: > > that's totally broken then. You cannot create an SMP-safe monotonic > > clocksource via interpolation - native does not do it either. Good thing > > this problem got exposed, it needs to be fixed. > > > > Sigh, I don't really want to have this fight again. i dont remember us having discussed this before, ever. If there's any "fight" about monotonicity and SMP then it would be a pretty onesided affair, with you being beaten up seriously ;-) > I don't really see what point there is in raising the tsc's rating > (why is 300 insufficient again?), but regardless of the value, the Xen > clocksource rating needs to be higher. anyway, i agree that this patch cannot go in in its current form. Ingo ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/