From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [ANNOUNCE] kvm-49 release Date: Fri, 2 Nov 2007 11:15:24 +0800 Message-ID: <200711021115.24505.sheng.yang@intel.com> References: <472A5D42.6080508@qumranet.com> Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_MZpKHO4vx/wbVXb" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity To: "Haydn Solomon" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org --Boundary-00=_MZpKHO4vx/wbVXb Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Friday 02 November 2007 10:14:35 Haydn Solomon wrote: > On Nov 1, 2007 9:54 PM, Haydn Solomon wrote: > > On Nov 1, 2007 9:36 PM, Sheng Yang wrote: > > > On Friday 02 November 2007 09:10:31 Haydn Solomon wrote: > > > > How can I tell that my cpu has flexpriority? > > > > > > > > (Resending this as didn't cc list last time.) > > > > > > Oops, forgot the patch... > > > > Thanks Sheng. > > > > Luckily for me I've got the Flexpriority feature > > > > [root@localhost winxptest]# dmesg | grep lex > > kvm: FlexPriority enabled! > > > > One thing I do notice apart from noticeably very good responsiveness and > > performance on windows guest ( xp sp2 ) is that this is the lowest cpu > > usage I've seen on the qemu kvm process to date. I haven't tried smp yet > > but that will be my next test and will report on how that goes. Thanks > > guys and well done! > > One issue I do see. When I run my windows xp guest which is ACPI > Multiprocessor PC HAL with -smp 2, it runs much slower and cpu usage is > high. Please try the attach patch. -- Thanks Yang, Sheng --Boundary-00=_MZpKHO4vx/wbVXb Content-Type: text/x-diff; charset="utf-8"; name="0001-KVM-VMX-Fix-repeatly-allocate-of-apic-access-page.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-KVM-VMX-Fix-repeatly-allocate-of-apic-access-page.patch" =46rom 8009718459efe41e0e8bc943a62734353c7828a2 Mon Sep 17 00:00:00 2001 =46rom: Sheng Yang Date: Fri, 2 Nov 2007 11:15:15 +0800 Subject: [PATCH] KVM: VMX: Fix repeatly allocate of apic access page =46or SMP guest, alloc_apic_access_page() would be called more than once. So only the last one works, causing SMP guest can't benifit from FlexPriori= ty. This patch fixed this issue. Signed-off-by: Sheng Yang =2D-- drivers/kvm/kvm_main.c | 1 + drivers/kvm/vmx.c | 2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c index 34a681d..519626d 100644 =2D-- a/drivers/kvm/kvm_main.c +++ b/drivers/kvm/kvm_main.c @@ -245,6 +245,7 @@ static struct kvm *kvm_create_vm(void) spin_lock(&kvm_lock); list_add(&kvm->vm_list, &vm_list); spin_unlock(&kvm_lock); + kvm->apic_access_page =3D NULL; return kvm; } =20 diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c index 42e7fad..de4441a 100644 =2D-- a/drivers/kvm/vmx.c +++ b/drivers/kvm/vmx.c @@ -1466,6 +1466,8 @@ static int alloc_apic_access_page(struct kvm *kvm) int r; =20 r =3D -EFAULT; + if (kvm->apic_access_page) + return 0; kvm_userspace_mem.slot =3D APIC_ACCESS_PAGE_PRIVATE_MEMSLOT; kvm_userspace_mem.flags =3D 0; kvm_userspace_mem.guest_phys_addr =3D 0xfee00000ULL; =2D-=20 1.5.2 --Boundary-00=_MZpKHO4vx/wbVXb Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --Boundary-00=_MZpKHO4vx/wbVXb Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --Boundary-00=_MZpKHO4vx/wbVXb--