From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: RFC/patch portability: split kvm_vm_ioctl v3 Date: Mon, 5 Nov 2007 11:03:59 +0100 Message-ID: <200711051104.01061.arnd@arndb.de> References: <1192192452.7630.16.camel@cotte.boeblingen.de.ibm.com> <200711051031.10846.arnd@arndb.de> <472EE682.9000202@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, Hollis Blanchard , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity , Christian Borntraeger , Martin Schwidefsky , "Zhang, Xiantao" To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <472EE682.9000202-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Monday 05 November 2007, Carsten Otte wrote: > > Actually, you have neither irq numbers nor vectors on s390 right now. > > I/O subchannels are do not fit into the IRQ handling in Linux at > > all, and external interrupts are sufficiently different that you > > should not treat them as IRQ lines in Linux. > The irq subsystem does not fit the external interrupt model, and you'd > definitely want to argue with Martin before suggesting to introduce > the IRQ subsystem on s390. "Only over my dead body" was the last > statement I do remember. Read again what I wrote above. I'm suggesting to have just one external interrupt for virtio and use the generic IRQ abstraction to handle everything that comes below that. > Plus I don't see a benefit from pretending to have an interrupt > controller: virtio abstracts from this, and can well be implemented > over extint and hypercall like Christian has done it. What's the > problem you're trying to solve? Sorry, I can't find Christian's code right now, do you have a pointer to the patches? I suspect that he has done exactly what I was trying to explain, except that the implementation is not using the generic IRQ layer, which means you're duplicating some of the code. Arnd <>< ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/