From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrea Arcangeli Subject: Re: Starting a VM reboots my machine Date: Mon, 5 Nov 2007 16:18:04 +0100 Message-ID: <20071105151804.GB6841@v2.random> References: <472A5561.5080202@cs.ualberta.ca> <64F9B87B6B770947A9F8391472E032160C95C59C@ehost011-8.exch011.intermedia.net> <20071104180538.GA6841@v2.random> <472F27BC.2060407@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Alexey Eremenko , kvm-devel To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <472F27BC.2060407-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Mon, Nov 05, 2007 at 04:25:00PM +0200, Avi Kivity wrote: > This one's obviously correct, will apply... thanks! >> Signed-off-by: Andrea Arcangeli >> >> index 9584d0f..95a3489 100644 >> --- a/drivers/kvm/svm.c >> +++ b/drivers/kvm/svm.c >> @@ -1459,11 +1459,6 @@ static void svm_vcpu_run(struct kvm_vcpu *vcpu, >> struct kvm_run *kvm_run) >> local_irq_enable(); >> - vcpu->guest_mode = 1; >> - if (vcpu->requests) >> - if (test_and_clear_bit(KVM_TLB_FLUSH, &vcpu->requests)) >> - svm_flush_tlb(vcpu); >> - >> asm volatile ( >> #ifdef CONFIG_X86_64 >> "push %%rbp; \n\t" >> >> > > Against which kvm is that? It isn't 2.6.24-rc, or kvm.git, or 2.6.23? I use the bleeding edge for userland and kernel, so kvm.git with "make sync". > Anyway, removing guest tlb flushing won't be good for the guest. Doesn't the common layer already take care of test_and_clearing that bitflag and calling kvm_x86_ops->tlb_flush before kvm_x86_ops->run in __vcpu_run? I thought it was an obsolete piece of code (besides it doesn't compile anyway it would need to be changed KVM_REQ_TLB_FLUSH) and it got re-introduced by mistake with a merging error in the last commit. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/