public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
To: Christian Borntraeger
	<borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel
	<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>,
	Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v2] kvm: Fix accounting of interrupts during guest	execution on s390
Date: Thu, 15 Nov 2007 15:18:10 +0100	[thread overview]
Message-ID: <20071115141810.GA729@elte.hu> (raw)
In-Reply-To: <200711151510.37076.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>


* Christian Borntraeger <borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> wrote:

> Avi pointed out, that my first patch was broken, here is the 2nd try. 
> I tested the patch on s390 with CONFIG_VIRT_CPU_ACCOUNTING and on 
> x86_64. Seems to work.
> 
> Currently the scheduler checks for PF_VCPU to decide if this timeslice 
> has to be accounted as guest time. On s390 host interrupts are not 
> disabled during guest execution. This causes theses interrupts to be 
> accounted as guest time if CONFIG_VIRT_CPU_ACCOUNTING is set. Solution 
> is to check if an interrupt triggered account_system_time. As the tick 
> is timer interrupt based, we have to subtract hardirq_offset.
> 
> Avi, Ingo, Laurent, feedback is welcome.

thanks, applied. I'll push this out as part of the scheduler git tree, 
ok?

	Ingo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

  parent reply	other threads:[~2007-11-15 14:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-14 15:32 [PATCH] kvm: Fix accounting of interrupts during guest execution on s390 Christian Borntraeger
     [not found] ` <200711141632.37004.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-11-14 15:36   ` Ingo Molnar
     [not found]     ` <20071114153651.GA3441-X9Un+BFzKDI@public.gmane.org>
2007-11-14 15:47       ` Christian Borntraeger
     [not found]         ` <200711141647.45810.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-11-14 16:04           ` Avi Kivity
     [not found]             ` <473B1C97.2010007-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-14 16:07               ` Christian Borntraeger
2007-11-15 14:10               ` [PATCH v2] " Christian Borntraeger
     [not found]                 ` <200711151510.37076.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-11-15 14:18                   ` Ingo Molnar [this message]
2007-11-15 14:23                   ` Avi Kivity
     [not found]                     ` <473C5652.9070706-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-15 14:38                       ` Christian Borntraeger
     [not found]                         ` <200711151538.16774.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-11-15 14:40                           ` Avi Kivity
2007-11-15 15:24                   ` Laurent Vivier
2007-11-15 15:56                     ` Christian Borntraeger
     [not found]                       ` <200711151656.44935.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-11-15 17:08                         ` Laurent Vivier
2007-11-15 18:05                           ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071115141810.GA729@elte.hu \
    --to=mingo-x9un+bfzkdi@public.gmane.org \
    --cc=Laurent.Vivier-6ktuUTfB/bM@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox