From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH v2] kvm: Fix accounting of interrupts during guest execution on s390 Date: Thu, 15 Nov 2007 15:18:10 +0100 Message-ID: <20071115141810.GA729@elte.hu> References: <200711141632.37004.borntraeger@de.ibm.com> <200711141647.45810.borntraeger@de.ibm.com> <473B1C97.2010007@qumranet.com> <200711151510.37076.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Laurent Vivier , Avi Kivity To: Christian Borntraeger Return-path: Content-Disposition: inline In-Reply-To: <200711151510.37076.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org * Christian Borntraeger wrote: > Avi pointed out, that my first patch was broken, here is the 2nd try. > I tested the patch on s390 with CONFIG_VIRT_CPU_ACCOUNTING and on > x86_64. Seems to work. > > Currently the scheduler checks for PF_VCPU to decide if this timeslice > has to be accounted as guest time. On s390 host interrupts are not > disabled during guest execution. This causes theses interrupts to be > accounted as guest time if CONFIG_VIRT_CPU_ACCOUNTING is set. Solution > is to check if an interrupt triggered account_system_time. As the tick > is timer interrupt based, we have to subtract hardirq_offset. > > Avi, Ingo, Laurent, feedback is welcome. thanks, applied. I'll push this out as part of the scheduler git tree, ok? Ingo ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/