From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 5/24] smp x86 consolidation Date: Sat, 17 Nov 2007 10:32:25 +0100 Message-ID: <20071117093224.GA32256@elte.hu> References: <11946337851964-git-send-email-gcosta@redhat.com> <11946337933104-git-send-email-gcosta@redhat.com> <11946337991750-git-send-email-gcosta@redhat.com> <11946338053158-git-send-email-gcosta@redhat.com> <11946338103068-git-send-email-gcosta@redhat.com> <1194633815833-git-send-email-gcosta@redhat.com> <4734FB67.8080500@goop.org> <4735098B.7040305@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: lguest-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jeremy Fitzhardinge , virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, ak-l3A5Bk7waGM@public.gmane.org To: Glauber de Oliveira Costa Return-path: Content-Disposition: inline In-Reply-To: <4735098B.7040305-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org * Glauber de Oliveira Costa wrote: > > I'm getting link errors in 32-bit: > > > > arch/x86/kernel/built-in.o: In function `native_smp_send_reschedule': > > /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/smpcommon.c:262: undefined reference to `genapic' > > arch/x86/kernel/built-in.o: In function `native_smp_call_function_mask': > > /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/smpcommon.c:113: undefined reference to `genapic' > > > Ok, it compiled just fine here. I bet it's due to one of that i386 lots > of variants. this patch is causing build failures all around the place. It does not build on CONFIG_X86_SUMMIT, it does not build if CONFIG_X86_GENERICARCH is turned off, etc. It does not even build on UP - fix for that is attached below. I've dropped this patch for now. Ingo --------------> Subject: x86: fix build error From: Ingo Molnar fix build error on !CONFIG_SMP. Signed-off-by: Ingo Molnar Signed-off-by: Thomas Gleixner --- include/asm-x86/smp.h | 2 ++ 1 file changed, 2 insertions(+) Index: linux/include/asm-x86/smp.h =================================================================== --- linux.orig/include/asm-x86/smp.h +++ linux/include/asm-x86/smp.h @@ -2,6 +2,7 @@ #define _X86_SMP_H_ #ifndef __ASSEMBLY__ +#ifdef CONFIG_SMP struct smp_ops { void (*smp_prepare_boot_cpu)(void); @@ -55,6 +56,7 @@ void native_smp_prepare_boot_cpu(void); void native_smp_prepare_cpus(unsigned int max_cpus); int native_cpu_up(unsigned int cpunum); void native_smp_cpus_done(unsigned int max_cpus); +#endif #ifndef CONFIG_PARAVIRT #define startup_ipi_hook(phys_apicid, start_eip, start_esp) \ ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/