public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Avi Kivity <avik-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: KVM: Use write_emulated and not write_std, which is not implemented
Date: Sun, 18 Nov 2007 22:48:19 +0530	[thread overview]
Message-ID: <200711182248.19902.amit.shah@qumranet.com> (raw)

>From 554315592b05eabf0355ac63145c28e11358af1f Mon Sep 17 00:00:00 2001
From: Amit Shah <amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Date: Sun, 18 Nov 2007 00:03:27 +0530
Subject: [PATCH] KVM: Use write_emulated and not write_std, which is not 
implemented

... and calling write_emulated should work just as well
in place of write_std.

Signed-off-by: Amit Shah <amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
---
 drivers/kvm/x86_emulate.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c
index 2765559..c2c9c8a 100644
--- a/drivers/kvm/x86_emulate.c
+++ b/drivers/kvm/x86_emulate.c
@@ -1076,9 +1076,10 @@ static inline int emulate_grp45(struct x86_emulate_ctxt 
*ctxt,
 		}
 		register_address_increment(c->regs[VCPU_REGS_RSP],
 					   -c->dst.bytes);
-		rc = ops->write_std(register_address(ctxt->ss_base,
-				    c->regs[VCPU_REGS_RSP]), &c->dst.val,
-				    c->dst.bytes, ctxt->vcpu);
+		rc = ops->write_emulated(register_address(ctxt->ss_base,
+						  c->regs[VCPU_REGS_RSP]),
+					 &c->dst.val,
+					 c->dst.bytes, ctxt->vcpu);
 		if (rc != 0)
 			return rc;
 		c->dst.type = OP_NONE;
-- 
1.4.4.2


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

             reply	other threads:[~2007-11-18 17:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-18 17:18 Amit Shah [this message]
     [not found] ` <200711182248.19902.amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-18 17:20   ` KVM: Use write_emulated and not write_std, which is not implemented Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711182248.19902.amit.shah@qumranet.com \
    --to=amit.shah-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=avik-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox