Re: How to handle kvm-abi-10 case for other archs.

Avi Kivity
2007-12-01T10:10:16Z

Zhang, Xiantao wrote:
> Hi, Avi
> I think new archs for kvm doesn't need to care about kvm-abi
> case in their code, since current abi is bigger than 10. But in current
> libkvm.c, we can see that many abi-specific code in it. How to handle it
> ? Can we use __x86__ macro to make it sightless for other archs or
> other good methods ?
>

#ifdef is okay for this. Actually we can probably remove abi 10 support
since the F7 kernel now supports the modern ABI (I don't think anybody
else uses abi 10, which is pre 2.6.22 when we announced ABI compatibility.

Jeremy, is removing abi 10 support fine with you? I note that both the
kernel supports the new ABI and F7 userspace doesn't require it, so
we're fine on both counts.

--
Any sufficiently difficult bug is indistinguishable from a feature.