From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: [Qemu-devel] Re: [PATCH 1 of 3] export SMBIOS/DMI tables to PC machines Date: Fri, 7 Dec 2007 15:13:18 -0600 Message-ID: <20071207211318.GG23913@us.ibm.com> References: <37bf559ffcf74bfe62ec.1197059815@localhost.localdomain> <4759B1A9.5080302@codemonkey.ws> <20071207205250.GF23913@us.ibm.com> <4759B559.1070405@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Ryan Harper , qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org To: Anthony Liguori Return-path: Content-Disposition: inline In-Reply-To: <4759B559.1070405-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org * Anthony Liguori [2007-12-07 15:07]: > Ryan Harper wrote: > >* Anthony Liguori [2007-12-07 14:49]: > > > >>>+ > >>>+CPUState *first_cpu; > >>> > >>> > >>This should probably be static. > >> > > > >doh, should be extern actually since it's defined elsewhere. > > > > Perhaps you want cpu_single_env instead of first_cpu? I wasn't quite sure given the comments surrounding its declaration: from exec.c: CPUState *first_cpu; /* current CPU in the current thread. It is only valid inside cpu_exec() */ CPUState *cpu_single_env; -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php