public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH] external module: <linux/string.h> needed for kernel<=2.6.16 to define strcmp and memcpy
Date: Wed, 19 Dec 2007 06:26:56 -0600	[thread overview]
Message-ID: <20071219122656.GC28788@tapir> (raw)
In-Reply-To: <4767F63A.9020701-atKUWr5tajBWk0Htik3J/w@public.gmane.org>

Fixes the following compilation error :

in file included from kernel/include/linux/kvm_para.h:19,
                 from kernel/external-module-compat.h:13,
                 from <command line>:1:
kernel/include/asm/kvm_para.h: In function 'kvm_para_available':
kernel/include/asm/kvm_para.h:87: warning: implicit declaration of function 'memcpy'
kernel/include/asm/kvm_para.h:92: warning: implicit declaration of function 'strcmp'
In file included from include/linux/string.h:24,
                 from include/linux/bitmap.h:8,
                 from include/linux/cpumask.h:86,
                 from include/linux/node.h:23,
                 from include/linux/cpu.h:23,
                 from kernel/external-module-compat.h:14,
                 from <command line>:1:
include/asm/string.h: At top level:
include/asm/string.h:104: error: static declaration of 'strcmp' follows non-static declaration

Signed-off-by: Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
---
 kernel/external-module-compat.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/external-module-compat.h b/kernel/external-module-compat.h
index 3794a99..c6a7d03 100644
--- a/kernel/external-module-compat.h
+++ b/kernel/external-module-compat.h
@@ -9,6 +9,7 @@
 
 #include <linux/compiler.h>
 #include <linux/version.h>
+#include <linux/string.h>
 #include "include/linux/kvm.h"
 #include "include/linux/kvm_para.h"
 #include <linux/cpu.h>
-- 
1.5.2.5


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

      parent reply	other threads:[~2007-12-19 12:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-18 13:00 [RFC] external module: compatibility with older kernels (SMP and non SMP) Carlo Marcelo Arenas Belon
2007-12-18 16:32 ` Avi Kivity
     [not found]   ` <4767F63A.9020701-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-19 12:18     ` [PATCH] external module: remove dependency on <asm/io_apic.h> Carlo Marcelo Arenas Belon
2007-12-19 15:44       ` Avi Kivity
2007-12-19 12:20     ` [PATCH] external module: define MAX_IO_APICS if missing Carlo Marcelo Arenas Belon
2007-12-19 12:26     ` Carlo Marcelo Arenas Belon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071219122656.GC28788@tapir \
    --to=carenas-kledwsohozojb6fo7hg9ng@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox